Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor optional column operations #696

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Refactor optional column operations #696

merged 1 commit into from
Mar 16, 2023

Conversation

cchantep
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #696 (03ac449) into master (a27b04b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
+ Coverage   95.00%   95.01%   +0.01%     
==========================================
  Files          65       65              
  Lines        1180     1183       +3     
  Branches       37       39       +2     
==========================================
+ Hits         1121     1124       +3     
  Misses         59       59              
Flag Coverage Δ
2.12.16 95.01% <100.00%> (+0.01%) ⬆️
2.13.10 95.61% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/src/main/scala/frameless/functions/package.scala 95.83% <ø> (ø)
dataset/src/main/scala/frameless/TypedColumn.scala 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cchantep cchantep requested a review from pomadchin March 16, 2023 14:33
Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@cchantep cchantep merged commit 65fad0a into master Mar 16, 2023
@cchantep cchantep deleted the feature/optcol branch March 16, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants