-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Stream#parJoin
for short-circuiting monad transformers
#2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r error; pass lease.cancel monad transformer errors to the result
mpilquist
approved these changes
May 2, 2022
SystemFw
reviewed
May 3, 2022
SystemFw
reviewed
May 3, 2022
diesalbla
reviewed
May 3, 2022
diesalbla
reviewed
May 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine to me, but will let @SystemFw give it the final 👍🏼 and merge.
diesalbla
approved these changes
May 3, 2022
SystemFw
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes hang of the following stream:
Problem description:
For the given stream
lease.cancel
raises monad transformer error, so the followingavailable.release >> decrementRunning
chain is not invoked and therefore output stream is not closed. But this is only a part of the problem, even if we close the stream, it will swallow monad error and return successful result.Fix description:
To fix the first part of the problem, I replaced
>>
monad composition withforceR
, that is fromMonadCancel
so should work fine for short-circuiting monad transformers. To fix the second part, I raisedlease.cancel
failures into effect, separated success cancel withguaranteeCase
and composed cancel result with the stream outcomeoc <* Outcome.succeeded(fu)
.