-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntax for the Logger
#568
Conversation
aee19ed
to
4673c28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever, but I'm not sure that I'd use it. Open to what others think.
@ChristopherDavenport would you check this, please? |
No one else hasn't expressed an opinion about this 😞 I'd be happy if can to decide on our own. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to refer to lexically-scoped loggers that log to a known category, rather than pass them as constraints, where I'm not sure what category they'll log to. Nor do I usually care to track logging as a capability. So I can't imagine myself using this.
However, you like it, it doesn't pollute the namespace without an import, and it doesn't bring in any dependencies. It's good for you and it won't hurt me. I say your 👍 weighs more than my 👎.
Thanks! Personally, I'm 50/50 about using logging via capabilities. But there is well known in one coterie logging library (tofu-logging), which promotes this approach pretty much. Therefore thinking about users familiar with that approach, it could be nice to have it in our's arsenal. |
This adds syntax that allows logging in that way: