-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LoggerFactory
docs
#642
Conversation
I will be pretty happy if @hamnis and @lorandszakacs can have to look at this. |
Great stuff! |
* you have control of loggers creation, and you can even add in whatever custom | ||
functionality you need for your applications here. E.g. create loggers that also push logs | ||
to some external providers by giving a custom implementation of this trait. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* you have control of loggers creation, and you can even add in whatever custom | |
functionality you need for your applications here. E.g. create loggers that also push logs | |
to some external providers by giving a custom implementation of this trait. | |
* you have control of loggers creation, and you can even add in whatever custom | |
functionality you need for your applications here by giving a custom implementation of this trait. For example, create loggers that also push logs to some external providers. |
describe the way before talking about examples
Looks good, I'd incorporate @FunFunFine's suggestions though |
I've tackled most of the comments, so probably this PR is quite ok to get merged. If anyone wants to continue improving these docs, don't be shy and open a PR. |
These docs are based on work made by @lorandszakacs in #421. So all credits go to them.
This covers a little part of the
LoggerFactory
, a basic functionality at most. It'd be great to complete it subsequently.