Pressure units #210
Merged
Pressure units #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekmorr
reviewed
Mar 16, 2017
|
|
||
| object Torr extends PressureUnit { | ||
| val symbol = "Torr" | ||
| val conversionFactor = Newtons.conversionFactor * 101325d / 760d |
There was a problem hiding this comment.
A Torr is "defined as exactly 1 / 760 of a standard atmosphere" (per wikipedia). So I wonder if conversionFactor would be better defined as StandardAtmospheres.conversionFactor / 760d ? It won't matter for correctness, but might make the definition easier to read.
…n the new unit classes
|
Did as suggested and also changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a couple of units of pressure used often in medicine and engineering