Fix Quantity hashcode method. #307
Conversation
|
Would you mind adding tests. This is serious enough to warrant some automated test |
|
I've added simple hashcode test. Is this enough? :) @cquiroz |
|
Anyone? @garyKeorkunian @cquiroz @nornagon |
|
That looks good for me |
|
Ok, so could you ack the review, because I cannot merge it without your permission? And what about releasing the new version? |
|
Thanks for the PR. Sorry for the delay. |
|
Whenever hashcode is invoked on the same object it should return the same value. This is the reason for this test. Thanks! :) |
| @@ -176,7 +178,9 @@ abstract class Quantity[A <: Quantity[A]] extends Serializable with Ordered[A] { | |||
| * | |||
| * @return | |||
| */ | |||
| override def hashCode() = toString.hashCode() | |||
| override def hashCode() = { | |||
| Objects.hash(dimension, Double.box(to(dimension.primaryUnit))) | |||
There was a problem hiding this comment.
Unfortunately, the resulting hashCode is not stable across JVM runs because the dimension itself may not have a stable hashCode.
Hi,
I've fixed hashcode method in Quantity class. The previous one was breaking the equals/hashcode conduct. It is a very serious bug, so please review it and merge if only possible.