Skip to content

Commit

Permalink
fix(eslint-plugin): strict config should not extend recommended (#5005)
Browse files Browse the repository at this point in the history
  • Loading branch information
JoshuaKGoldberg authored May 17, 2022
1 parent e18e91c commit 05d71c2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 11 deletions.
7 changes: 1 addition & 6 deletions packages/eslint-plugin/src/configs/strict.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,7 @@
// YOU CAN REGENERATE IT USING yarn generate:configs

export = {
extends: [
'./configs/base',
'./configs/eslint-recommended',
'./configs/recommended',
'./configs/recommended-requiring-type-checking',
],
extends: ['./configs/base', './configs/eslint-recommended'],
rules: {
'@typescript-eslint/array-type': 'warn',
'@typescript-eslint/ban-tslint-comment': 'warn',
Expand Down
6 changes: 1 addition & 5 deletions packages/eslint-plugin/tools/generate-configs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -240,11 +240,7 @@ const strictRules = ruleEntries.filter(entryIsStrict).reduce<LinterConfigRules>(
{},
);
const strictConfig: LinterConfig = {
extends: [
...EXTENDS,
'./configs/recommended',
'./configs/recommended-requiring-type-checking',
],
extends: EXTENDS,
rules: strictRules,
};
writeConfig(strictConfig, path.resolve(__dirname, '../src/configs/strict.ts'));

0 comments on commit 05d71c2

Please sign in to comment.