fix(type-utils): union types always being marked as readonly (#4419)

typescript-eslint · Jan 17, 2022 · 99ab193 · 99ab193
1 parent ef3147c
commit 99ab193
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/packages/type-utils/src/isTypeReadonly.ts b/packages/type-utils/src/isTypeReadonly.ts
@@ -216,7 +216,8 @@ function isTypeReadonlyRecurser(
     const result = unionTypeParts(type).every(
       t =>
         seenTypes.has(t) ||
-        isTypeReadonlyRecurser(checker, t, options, seenTypes),
+        isTypeReadonlyRecurser(checker, t, options, seenTypes) ===
+          Readonlyness.Readonly,
     );
     const readonlyness = result ? Readonlyness.Readonly : Readonlyness.Mutable;
     return readonlyness;

diff --git a/packages/type-utils/tests/isTypeReadonly.test.ts b/packages/type-utils/tests/isTypeReadonly.test.ts
@@ -137,6 +137,33 @@ describe('isTypeReadonly', () => {
           );
         });
       });
+
+      describe('Union', () => {
+        describe('is readonly', () => {
+          const runTests = runTestIsReadonly;
+
+          it.each([
+            [
+              'type Test = Readonly<{ foo: string; bar: number; }> & Readonly<{ bar: number; }>;',
+            ],
+            ['type Test = readonly string[] | readonly number[];'],
+          ])('handles a union of 2 fully readonly types', runTests);
+        });
+
+        describe('is not readonly', () => {
+          const runTests = runTestIsNotReadonly;
+
+          it.each([
+            ['type Test = { foo: string; bar: number; } | { bar: number; };'],
+            [
+              'type Test = { foo: string; bar: number; } | Readonly<{ bar: number; }>;',
+            ],
+            [
+              'type Test = Readonly<{ foo: string; bar: number; }> | { bar: number; };',
+            ],
+          ])('handles a union of non fully readonly types', runTests);
+        });
+      });
     });
 
     describe('treatMethodsAsReadonly', () => {