-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: basic setup for benchmarks #134
Conversation
small update: i added additional test case when we try to process multiple files and looks like in this case tslint wins, we are not preserving Program, and parser has to do everythink from start: // 1 file
tslint x 2.56 ops/sec ±9.62% (11 runs sampled)
eslint x 2.59 ops/sec ±6.59% (11 runs sampled)
Fastest is [ 'eslint', 'tslint' ]
// 3 files
tslint x 2.41 ops/sec ±9.04% (11 runs sampled)
eslint x 0.83 ops/sec ±2.93% (7 runs sampled)
Fastest is [ 'tslint' ] more files we add to project, parser is creating more instances of |
@armano2 That's definitely a bug on me, then. The intent was absolutely to preserve the |
@armano2 Is this marked as DO NOT MERGE because you are still working on it? Or do you not think we should merge it in general? |
Seems like it might be good to have a consistent benchmark to iterate against when fixing the performance issue |
i'm still working on it, and i'm unsure if we should merge it :) |
Should we rename “DO NOT MERGE” to “WIP” and just close PRs we don’t plan to merge? This would also allow the |
i did some profiling on all steps, and running parser take alot of time
parser is way way slower than it should, i have some profiles and i will continue to investigate |
I will begin working on refactoring the TypeScript Program logic this evening - I will keep you in the loop @uniqueiniquity |
…eServices" This reverts commit 358d0a6.
speeds are looking better! |
Speaking with @uniqueiniquity we have some code in right now designed with the long running (e.g. in editor/IDE) process in mind. It would be ideal if we could add some benchmark around "watch" performance as well, although I appreciate that is less straightforward |
Closing this for housekeeping purposes. |
update:
Single File: restrict-plus-operands
Multi File: restrict-plus-operands
Single File: no-empty-interface
Multi File: no-empty-interface
#130 (comment)
@aboyton @JamesHenry @uniqueiniquity @scottohara #55