Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): truncate number of files printed by the maximum file error #9127

Merged
merged 2 commits into from
May 24, 2024

Conversation

domarmstrong
Copy link
Contributor

  • fix(typescript-estree): truncate number of files printed

Address issue with size of error string produced causing serialization failure #9124.

  • test(typescript-estree): add additional unit test for project service

Additional test for truncated error message.

PR Checklist

Overview

* fix(typescript-estree): truncate number of files printed

Address issue with size of error string produced causing serialization failure typescript-eslint#9124.

* test(typescript-estree): add additional unit test for project service

Additional test for truncated error message.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @domarmstrong!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 22, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0c6b45c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665056139a3d85000837ee21
😎 Deploy Preview https://deploy-preview-9127--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

Katy Perry giving the 'chefs kiss' sign

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label May 24, 2024
Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating and fixing this!

@auvred auvred merged commit c4f211f into typescript-eslint:main May 24, 2024
59 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: "Invalid string length" caused by allowDefaultProjectForFiles warning
3 participants