Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-dynamic-delete] allow all string literals as index #9280

Merged

Conversation

Josh-Cena
Copy link
Member

PR Checklist

Overview

Also tightened the condition for unary expressions, which I consider a bug (it allows typeof 1)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4f7a606
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66609e4a5c1a54000805a811
😎 Deploy Preview https://deploy-preview-9280--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jun 5, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blast from the past, I'd forgotten about this! Nice!

Christopher Walken dramatically looking up, smiling, hitting his hands together, and then giving a thumbs up

(once the lint complaints are fixed)

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 5, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit fb52f78 into typescript-eslint:main Jun 8, 2024
61 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-dynamic-delete] Compatibility with typescript's noPropertyAccessFromIndexSignature
2 participants