Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add django-stubs, djangorestframework-stubs to allowlist #111

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Oct 22, 2023

Prerequisite for python/typeshed#10919

Neither package appears in the PyPI top 1000 list. django-stubs is nr 1686 and djangorestframework-stubs is nr 2039.

But @sobolevn can vouch for the fact that these dependencies aren't evil 😈

@intgr
Copy link
Contributor Author

intgr commented Oct 22, 2023

Actually this probably won't work because "we ensure that external dependencies of a stub package must be a dependency of the upstream package" (#90 (comment)). Pending further discussion in typeshed PR.

@intgr intgr marked this pull request as draft October 22, 2023 11:49
Copy link
Contributor

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am actually not very familiar with what stub-uploader does.
I tried to stay as far away from distribution as possible 😆

@srittau srittau marked this pull request as ready for review July 15, 2024 13:53
@srittau srittau merged commit 0eef554 into typeshed-internal:main Jul 15, 2024
3 checks passed
@intgr
Copy link
Contributor Author

intgr commented Jul 15, 2024

Thanks! I don't remember the details, but back when I opened this PR, it seemed to be blocked.

Did you take a look at the issue linked from #111 (comment) and it's no longer relevant?

@intgr intgr deleted the allow-django-stubs branch July 15, 2024 13:55
@AlexWaygood
Copy link
Contributor

Yeah, the stub-uploader tests are still failing on python/typeshed#10919 despite this change, because of #111 (comment)

@intgr
Copy link
Contributor Author

intgr commented Jul 15, 2024

Indeed, from job output https://github.com/python/typeshed/actions/runs/9940724727/job/27458123648?pr=10919

E stub_uploader.metadata.InvalidRequires: Expected dependency django-stubs to be listed in django-filter's requires_dist or the sdist's *.egg-info/requires.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants