-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: forbidUnknownValues should default true when validatorOptions undefined #2196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes, but this looks good!
Thanks for your review @braaar. I just made changes based on your feedback. Hopefully it's good to merge now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should maybe add a test where you pass {}
as the options
object
@braaar Good idea. Done. |
@braaar any other changes needed to get this merged? |
Probably not, but we'll have to wait for @NoNameProvided's review |
@braaar I just made another commit based on your feedback. Let me know if anything else is required to get this merged. |
Any chance of getting this small PR reviewed & merged @NoNameProvided? |
@braaar @NoNameProvided Any chance of getting this small PR reviewed & merged? |
Thanks for the contribution! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
forbidUnknownValues
is supposed to default totrue
. This wasn't the case whenvalidatorOptions
wasundefined
. This PR corrects that and adds a test for it. It also corrects some related code doc.Checklist
Update index.md
)develop
)npm run prettier:check
passesnpm run lint:check
passesFixes
fixes #1906