Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the dataflow manual section about shading. #4681

Merged
merged 4 commits into from
May 26, 2021
Merged

Update the dataflow manual section about shading. #4681

merged 4 commits into from
May 26, 2021

Conversation

smillst
Copy link
Member

@smillst smillst commented May 20, 2021

No description provided.

mernst
mernst approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@mernst mernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the text to put the directive first and the motivation afterward.
Could you double-check it and merge when you are satisfied?

Thanks!

@mernst mernst assigned smillst and unassigned mernst May 24, 2021
@smillst smillst merged commit 061fb74 into typetools:master May 26, 2021
@smillst smillst deleted the dataflow-manual-shaded branch May 26, 2021 16:52
wmdietl pushed a commit to eisop/checker-framework that referenced this pull request Jul 22, 2021
@smillst @wmdietl
Update the dataflow manual section about shading. (typetools#4681)
55a29b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mernst mernst mernst approved these changes

Assignees

@smillst smillst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smillst @mernst