Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error checking when dbName doesn't exist in acquiacli db:backup:download #46

Closed
generalredneck opened this issue Mar 10, 2020 · 0 comments
Labels
Milestone

Comments

@generalredneck
Copy link

Just putting this here to make things a little bit better, not trying to nit pic :)

Is your feature request related to a problem? Please describe.
When I had a typo in the dbName parameter in the db:backup:download command I just recieved some PHP notice and an error saying a resource didn't exist.

Describe the solution you'd like
Lets throw an error if $backup is an empty arrayobject. Dumping it on line 182 gave me

object(AcquiaCloudApi\Response\BackupsResponse)#595 (1) {
  ["storage":"ArrayObject":private]=>
  array(0) {
  }
}

because the query before returned 0 results.

Additional context
Add any other context or screenshots about the feature request here.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants