Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support query params in rewrites #372

Closed
ashleahhill opened this issue Sep 28, 2016 · 0 comments · Fixed by #373
Closed

Support query params in rewrites #372

ashleahhill opened this issue Sep 28, 2016 · 0 comments · Fixed by #373

Comments

@ashleahhill
Copy link
Contributor

I'm working on a project with composite ids for data entries. In order to query a particular record using JSON Server, I need to write a rewrite like this:

const rewrites = {
  '/records/:idpartone-:idparttwo/': '/records/?id.partone=:idpartone&id.parttwo=:idparttwo'
};

The rewriter correctly rewrites the url, however the new query params are not parsed. The end result is that a request to /records/:idpartone-:idparttwo/ will return the full set of /records/.
ashleahhill pushed a commit to Q-Free-OpenRoads/json-server that referenced this issue Sep 28, 2016
Add support for query params in rewrite targets
46dde0b 
Re-parse the rewrite target to add query params, fixes typicode#372
This was referenced Sep 28, 2016
Merged
Closed
typicode pushed a commit that referenced this issue Oct 1, 2016
@ashleahhill @typicode
Add support for query params in rewrite targets (#373)
b06bc27 
* Add support for query params in rewrite targets

Re-parse the rewrite target to add query params, fixes #372

* Use lodash for Object.assign for node v0.12 compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for query params in rewrite targets Q-Free-OpenRoads/json-server
1 participant
@ashleahhill