-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persistent = false #275
Open
ortegafernando
wants to merge
40
commits into
tzapu:master
Choose a base branch
from
kentaylor:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Persistent = false #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an be unique and automatically generated from the ESP8266 Chip Id. Tries to reconnect in station mode with whatever credentials have been saved when StartConfigPortal times out otherwise device will be without WiFi after exiting StartConfigPortal.
…t Wifi already does it's best to connect in the background. Calling WiFi.begin while device is already trying to connect will occasionally cause WiFi to lock up. Only call WiFi.begin after calling WiFi.disconnect. These changes are aimed at stopping WiFi.begin from being called at the wrong time. The concept of autoconnect is also deprecated because it is trying to do what the device is already doing. Calling this method will now block until WiFi connects. It has been changed to wait for 10 seconds then go into setup mode if connection fails. Sketch can avoid blocking call then use (WiFi.status()==WL_CONNECTED) test to see if connected yet. Removed - Tries to reconnect in station mode with whatever credentials have been saved when StartConfigPortal times out otherwise device will be without WiFi after exiting StartConfigPortal. - because it was wrong.
…onfiguration portal otherwise connect with existing SSID data. If a button is pushed go into configuration portal mode. Stay in configuration portal mode until user closes configuration portal or 3 minutes have passed.
…specified time has passed or user requests portal to be closed. If a successful connection is made to a network the access portal is available on the network ip address and on it's own network at two addresses. These addresses are 192.168.1.4 and the address on the other network.
…rds do not have this led. Force to station mode on example app because if device was switched off while in access point mode it will start up next time in access point mode. Print ip number correctly in close page Set example app to keep access point open forever. Turn off automatic scans for wifi. Add current network and IP details to root page. Removed reset button from root page as I can't think of a scenario where this is useful but url for reset functionality still works. Make device reset in example app after returning from portal because web server can only be started once. Not sure why this is and it needs further investigation. After setting credentials redirect to root page rather than serve a page. Set header responses to not cache in browser for all pages. Removed generate_204 handler. See discussion in code as to why.
…nnected to network so change to access point mode only when there is no network connection. Provide some extra information on the root page. Disabled page caching in the browser.
# Conflicts: # WiFiManager.cpp
Output from url /state now parses OK at test site http://json.parser.online.fr/
…est to be of type boolean from previous type string. Moved scan for WiFi networks to a seperate function. Uses the third option from https://www.eskimo.com/~scs/cclass/int/sx5.html to return an array which is messy as it requires the use of pointers, malloc and free. The function returns the number of WiFi networks it found and changes a pointer to point to an array of indexes that is used to access the WiFi networks that were found array in signal strength order. Changed the ConfigOnSwitch example to use waitForConnectedResult method rather than poll in a loop for the WiFi status when attempting to connect to WiFi.
…on format. The purpose of returning data in json format is to make it easy for apps to programatically configure the WiFi access point name and credentials. I expect users will find apps a convenient alternative to a browser to configure the device because usability testing has shown that people sometimes get confused by having to switch back and forward between WiFi networks . The URLs that return json data are now /state and /scan .
Removed examples that were no longer meaningful now that the autoconnect function has been deprecated.
…ecting to a network. Changed pin assignments to be numerical rather than by name as some ESP8266 devices use different pin mappings. Small modifications to librarly explanation and justification.
- Configuration portal got new look and feel - Added a very small CSS framework based on mincss - Added the possibility of using labels. A labels will receive the text of the corresponding placeholder - Added option for label placement. 0 - label not displayed, 1 - label displayed before field (default), 2 - label displayed after field. Latter is useful for checkboxes - Scan link was moved to the top - All HTML <dl> description list elements were replaced by tables - Removed <br> before each form parameter, CSS will take care of the spacing and custom HTML injection will be more useful - Renamed Configure WiFi option to Configuration as WiFi is not the only option that can be configured - Renamed Info option to WiFi Information as the original text was too short and looked strange - Reanmed Close configuration portal option as it was too long and was displayed in two lines on smaller devices
…s saved to the flash memory
…ly working correctly. This did not affect the ConfigOnSwitch example. 2. Provided ConfigOnStartup example as suggested by cjamin. This provides a ConfigPortal for the first minute after startup. 3. Changed logic in ConfigOnSwitch example when there is no previously configured access point to match that in ConfigOnSwitchFS example. 4. Fixed broken link in Readme.MD.
…oved config file writing process
Added SSID and Station IP to Device Information web page at address /i
1. Updated explanation on first page of repository to reflect many changes that have been made since the earlier version. 2. Page requests to root redirect to a fixed url which also resolves to an information page on the internet. 3. Changed password field to an ordinary input to make password visible while typing. 4. Added link to associated Android app, connection status report and reference of available pages to information page. 5. Corrected explanation in comments of why dual mode can become flaky. 6. Removed all references to generate_204 which is no longer used.
…eset is detected.
Added an example of starting the configuration portal when a double reset is detected.
…t example. Also web wifisave page changed to show actual access point name rather than a constructed name that may be wrong.
… to creating a WiFi network. This removes the risk of the browsing device that is using the html interface changing WiFi networks during a scan but means WiFiManager must be restarted to update the scan results at /wifi. The /scan URL still does a fresh scan on each request and these scan results are exclusive for the JSON interface.
…way to load parameters other than WiFi parameters. Removed unused WlFiManager status conditions. Fixed broken hyperlinks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i don't know exactly how I could open an issue here, or send you a private email, so I have open a pull request to ask you for this:
#242 (comment)
What do you think ???
Hope your answer.
Regards,