json-prune doesn't work on uBO

[Yuki2718]

https://www.msn.com/en-xl/news/other/21-famously-faulty-classic-cars/ss-AA19wOd5
msn.com#%#//scriptlet('json-prune', 'configs.*.properties.slideshowWCSettings.interstitialNativeAds configs.*.properties.fullScreenSlideshowSettings.interstitialNativeAds properties.componentConfigs.slideshowConfigs.interstitialNativeAds') works on AG, not on uBO. In the similar vein, misskey.io##+js(json-prune, ads.[].imageUrl) for https://misskey.io/@kureharu_stk works only on AG. I thought there was some changes made for yt which made incompatibility, but can these be fixed?

[Yuki2718]

For both cases json-prune-fetch-response works.

[gorhill]

But you said same filters work with AG but not uBO -- this is what I want to investigate.

For https://misskey.io/@kureharu_stk, stepping into the code I didn't see any instances of ads.[].imageUrl, the closest I saw was ads.[].url.

[Yuki2718]

It's logged only by json-prune The ads are misskey.io##.xF6dY.

[Yuki2718]

MSN ad is the same as AdguardTeam/AdguardFilters#173054, blank slides. May need US IP. Found your comment I tried to mention in OP https://github.com/uBlockOrigin/uBlock-discussions/discussions/789#discussioncomment-6802445 (whoops, but does not open thx to be folded. Expand https://github.com/uBlockOrigin/uBlock-discussions/discussions/789#discussioncomment-6501001)

[gorhill]

The explanation is that uBO json-prune doesn't trap Response.prototype.json while it does in AdGuard. uBO's json-prune used to also trap Response.prototype.json, but this was changed in this commit because a specialized json-prune-fetch-response was spun off to avoid trapping unnecessarily. AdGuard doesn't have json-prune-fetch-response.

[Yuki2718]

Yeah, that's what I forgot and initially confused. But shouldn't json-prune-fetch-response log ads.[].imageUrl and json-prune not?

[gorhill]

I didn't see imageUrl reported by +js(json-prune). As for +js(json-prune-fetch-response), looking at the code, it's not set up to log like json-prune -- I will try to remember to support this in current dev cycle.

[gorhill]

gorhill/uBlock@e527a8f

[Yuki2718]

www.msn.com##+js(json-prune-fetch-response, properties.componentConfigs.slideshowConfigs.slideshowSettings.interstitialNativeAds, , propsToMatch, url:consumptionpage/gallery_windows/config.json) removes ad placeholder in slides on https://www.msn.com/en-us/health/wellness/18-american-phrases-that-non-americans-struggle-to-understand/ss-AA1nbhpn?ocid=winp1taskbar&cvid=ad2460971cdc406fa2002b8e2dd27977&ei=6#image=21 but nothing about interstitialNativeAds is logged with

msn.com##+js(json-prune)
msn.com##+js(json-prune-fetch-response)

Same with v1.54.

[gorhill]

Sorry, not understanding what you are reporting.

[Yuki2718]

Just wondering why interstitialNativeAds never appers in logs while pruning this fixes ad placeholder.

[gorhill]

Is the pruning really being applied? I don't see it being reported in the logger, and placeholders are not removed.

msn.com##+js(json-prune-fetch-response)

why interstitialNativeAds never appers in logs

I do see one reported line:

---

Note that on my side the JSON paths to interstitialNativeAds are:

properties.slideshowWCSettings.interstitialNativeAds
properties.fullScreenSlideshowSettings.interstitialNativeAds

[Yuki2718]

They are old paths (see AdguardTeam/AdguardFilters@f2dd575) and on my end no more used.