Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entire uBlock pop-up GUI not visible #1254

Closed
5 of 8 tasks
Bartolomeus-649 opened this issue Sep 20, 2020 · 5 comments
Closed
5 of 8 tasks

Entire uBlock pop-up GUI not visible #1254

Bartolomeus-649 opened this issue Sep 20, 2020 · 5 comments
Labels
Chromium specific to Chromium/Chrome external issue involving an external factor fixed issue has been addressed

Comments

@Bartolomeus-649
Copy link

Bartolomeus-649 commented Sep 20, 2020

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

[Description of the bug or feature]
The main POP-UP GUI is only partly visible on screen. Thelocation of the POP-UP GUI depends on where in the tool-bar the uBlock icon is displayed.

A specific URL where the issue occurs

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]
N/A

Steps to Reproduce

  1. [First Step] Click the uBlock icon in the tool-bar
  2. [Second Step]
  3. [and so on...]

Expected behavior:

[What you expected to happen]
To see the entire uBlock GUI on the screen.

Actual behavior:

[What actually happened]
image
image

Your environment

  • uBlock Origin version: 1.29.2
  • Browser Name and version: Google Chrome is up to date, Version 85.0.4183.102 (Official Build) (64-bit)
  • Operating System and version: Microsoft Windows [Version 10.0.18363.1016] (Windows 10 x64, Ent. Eng.)
@gorhill
Copy link
Member

gorhill commented Sep 20, 2020

What is the resolution of your screen?

Your browser is responsible for supplying the viewport in which the popup panel is rendered, so if the viewport set by the browser extend beyond the screen, this is a browser issue. The only workaround I see is to reduce the text size of the popup panel.

You will have to open an issue with the browser developers -- there was a similar issue somewhere which was closed as a browser issue, I can't find it at the moment.

@gwarser gwarser added Chromium specific to Chromium/Chrome external issue involving an external factor labels Sep 20, 2020
@Bartolomeus-649
Copy link
Author

Widows resolution is 1920 x 1080 with a scale of 150% (Recommended)

image

I tried to change the zoom-level in chrome, but it had no effect at all.

I tried your suggestion to set font size, and with it set to 0.8rem it fits on the screen.
image

Would it be possible to use any of the other advanced setting to affect this issue?

Suggestion: A "Narrow mode" would be great, where paddings and margins are set to a minimum. Alternatively, add a padding/margins setting to the advanced settings..

gorhill added a commit to gorhill/uBlock that referenced this issue Sep 21, 2020
Related issue:
- uBlockOrigin/uBlock-issues#1254

The advanced setting `uiStyles`[1] can be used to control
the minimum width of both the main and firewall panes
in the popup panel:

- `--popup-main-min-width`, default to `18em`
- `--popup-firewall-min-width`, default to `30em`

* * *

[1] https://github.com/gorhill/uBlock/wiki/Advanced-settings#uistyles
@gorhill
Copy link
Member

gorhill commented Sep 21, 2020

In the latest dev build, you can adjust the minimum width of both the main and firewall panes by using the following CSS properties in the advanced setting uiStyles:

--popup-firewall-min-width:24em;

For reference, the current default minimum width for the firewall pane is 30em.

You can also modify the minimum width for the main pane -- which default to 18em:

--popup-main-min-width:16em;

You can customize both:

--popup-main-min-width:16em;--popup-firewall-min-width:24em;

I consider this should take care of the issue for now since so far you are the only person having reported such issue.

@Bartolomeus-649
Copy link
Author

Ok, but isn't max-width what I would need in my case? I mean, min-with prevents something from getting to small, right?

@gorhill
Copy link
Member

gorhill commented Sep 21, 2020

I don't think max-width is reached in your case, so it's not the property which will have an effect, and in any case min-width has priority over max-width. If you set min-width to unset you will see that the popup panel will be too narrow to be usable.

@gorhill gorhill closed this as completed Sep 22, 2020
@uBlock-user uBlock-user added the fixed issue has been addressed label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium specific to Chromium/Chrome external issue involving an external factor fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants