Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmetic filter ## selector is valid in element picker only #1280

Closed
7 of 8 tasks
krystian3w opened this issue Oct 5, 2020 · 1 comment
Closed
7 of 8 tasks

cosmetic filter ## selector is valid in element picker only #1280

krystian3w opened this issue Oct 5, 2020 · 1 comment
Labels
bug Something isn't working fixed issue has been addressed

Comments

@krystian3w
Copy link

krystian3w commented Oct 5, 2020 •
edited
Loading

cosmetic filter ## selector is valid in element picker only

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

open any page e.g. Google, activate element picker interface, put in the text area:

## body

Filter hide something (not <body>), but "my filters" tab marked as invalid

obraz obraz

similar/related: #1118 / #1134

A specific URL where the issue occurs

google.com

Steps to Reproduce

  1. open google site or any other
  2. try hide someting with element picker
  3. change proposition to ## body
  4. element picker still hide old element (not <body>)
  5. possible save filter

Expected behavior:

Mark these cosmetic filters as invalid in element picker too

Actual behavior:

  • Filter generate FP about works in element picker

  • In the past normal works in uBO / AdGuard (AdGuard still valid ## body as ##body)

Your environment

  • uBlock Origin version: 1.30.0
  • Browser Name and version: Firefox 81.0.1
  • Operating System and version: Windows 10
@uBlock-user
Copy link
Contributor

Should be rejected in the the element picker itself.

@uBlock-user uBlock-user added the something to address something to address label Oct 5, 2020
gorhill added a commit to gorhill/uBlock that referenced this issue Oct 8, 2020
@gorhill
Improve bad filter detection in element picker
c3f267d 
Related issue:
- uBlockOrigin/uBlock-issues#1280
@gwarser gwarser closed this as completed Oct 8, 2020
@gwarser gwarser added bug Something isn't working fixed issue has been addressed and removed something to address something to address labels Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gwarser @uBlock-user @krystian3w