Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMTL filtering with procedural filters broken in dev releases past 1.44.5b0 #2294

Closed
8 tasks done
u-RraaLL opened this issue Sep 26, 2022 · 2 comments
Closed
8 tasks done
Labels
bug Something isn't working fixed issue has been addressed

Comments

@u-RraaLL
Copy link
Contributor

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For any support, questions or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

When I updated to 1.44.5b3 yesterday I noticed some of my filters stopped working. In the end I narrowed it down to HTML filters.

After some trial and error it seems that filters such as example.com##^element:not(:has-text(example)) won't work if compiled on 1.44.5b3+.
The filters do work if compiled on 1.44.5b0, after update to a higher version. But they stop working after recompiling. So on any change to My filters.

A specific URL where the issue occurs.

https://old.reddit.com/r/uBlockOrigin/

Steps to Reproduce

  1. Install uBO 1.44.5b3-b5.
  2. Visit https://old.reddit.com/r/uBlockOrigin/
  3. Add this filter old.reddit.com##^.link:not(:has-text(Solved)) and Apply.
  4. Refresh uBO's sub.
  5. See the filter fail.
  6. Drop down to uBO 1.44.5b0.
  7. Recompile filters by making any change in My filters and hitting apply.
  8. Visit uBO's sub again and see the filter work as expected.

Expected behavior

HTML filters using procedurals working normally.

Actual behavior

They don't work past 1.44.5b0.

uBO version

1.44.5b3-b5

Browser name and version

Firefox 104.0.2

Operating System and version

MX Linux 21.2

@shrekisallah
Copy link

I think its because of this gorhill/uBlock@a71b71e

gorhill added a commit to gorhill/uBlock that referenced this issue Sep 27, 2022
@gorhill
Copy link
Member

gorhill commented Sep 27, 2022

I committed unrelated changes by accident.

@gwarser gwarser added bug Something isn't working fixed issue has been addressed labels Sep 27, 2022
@gwarser gwarser closed this as completed Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants