Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack as a peer dependency to silent unmet peer dependency warnings #1532

Merged
merged 2 commits into from
Mar 9, 2020

Conversation

murny
Copy link
Contributor

@murny murny commented Mar 9, 2020

Cleans up these kind of warnings:

[1/5] :mag:  Resolving packages...
[2/5] :truck:  Fetching packages...
[3/5] :link:  Linking dependencies...
warning " > [email protected]" has unmet peer dependency "webpack@^2.0.0 || ^3.0.0 || ^4.0.0".
warning " > [email protected]" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning "webpack-dev-server > [email protected]" has unmet peer dependency "webpack@^4.0.0".

Webpacker has a dependency already on webpack so these warnings are harmless. But we get them as the above packages want webpack to be a peer dependency (webpack be added to our projects dependencies). So let's just silent them by adding webpack to our project using resolutions.

More info from webpack: rails/webpacker#1078

@murny murny merged commit cb49bbc into integration_postmigration Mar 9, 2020
@murny murny deleted the silent-webpack-warnings branch March 9, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants