Force ActiveStorage to use minimagick as this is what we currently use in staging/production #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in staging/production
pgwillia
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Nice catch! 👍 This was the one remaining config detail from https://github.com/ualbertalib/library-cms/pull/512/files#diff-eea1c50635a8c62e2b5a61e4e6526c06b9a172c2c7eb6e071dc4b42722b8d5f6L83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I removed Rails 7.0 defaults, it swapped us to the new default for ActiveStorage which is using VIPS.
We currently don't have libvips installed in staging/production so we are seeing some errors for this when I was testing
1.9.0release on staging.https://app.rollbar.com/a/ualbertalib/fix/item/library-cms/5
Let's force this to the previous default, which was
mini_magick