Testing/client tests #573
Merged
Testing/client tests #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaoharry
requested review from
mRabitsky,
bobheadxi,
kimoantiqe,
nicholaschinjie,
seifghazi,
terryz21 and
a team
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
==========================================
+ Coverage 56.08% 56.51% +0.44%
==========================================
Files 62 62
Lines 3019 3019
==========================================
+ Hits 1693 1706 +13
+ Misses 1119 1104 -15
- Partials 207 209 +2
Continue to review full report at Codecov.
|
bobheadxi
reviewed
Feb 16, 2019
| err = client.DaemonDown() | ||
| assert.Nil(t, err) | ||
| println(actualCommand) | ||
| assert.Equal(t, actualCommand, session.Calls[0]) |
There was a problem hiding this comment.
wouldn't this actually be testing daemon-up.sh? see line 139 🤔
…d/inertia into testing/client-tests
terryz21
approved these changes
Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Ticket(s): Closes #
👷 Changes
Increased code coverage for client.go by adding test cases for TOTP, daemon down and ssl verification.
🔦 Testing Instructions
Run test cases for
client_test.go