Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update for new config format and commands #587

Merged
merged 3 commits into from
Feb 26, 2019
Merged

docs: update for new config format and commands #587

merged 3 commits into from
Feb 26, 2019

Conversation

bobheadxi
Copy link
Member

🎟️ Ticket(s): Closes #581

👷 Changes

  • update usage guide for new config format and commands
  • update CONTRIBUTING for new commands
  • misc wording improvements

🔦 Testing Instructions

make run-docs-usage

@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Feb 26, 2019
@bobheadxi bobheadxi requested a review from a team February 26, 2019 02:58
@bobheadxi bobheadxi changed the title Docs/#581 new cfg docs: update for new config format and commands Feb 26, 2019
yaoharry
yaoharry requested changes Feb 26, 2019
View reviewed changes
docs_src/index.html.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 26, 2019 •
edited
Loading

Codecov Report

Merging #587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   55.36%   55.36%           
=======================================
  Files          67       67           
  Lines        3004     3004           
=======================================
  Hits         1663     1663           
  Misses       1145     1145           
  Partials      196      196

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2d0de4...f75be7e. Read the comment docs.

@bobheadxi bobheadxi merged commit 6feabe4 into master Feb 26, 2019
@bobheadxi bobheadxi deleted the docs/#581-new-cfg branch February 26, 2019 05:19
@bobheadxi bobheadxi mentioned this pull request Feb 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaoharry yaoharry yaoharry approved these changes

@kimoantiqe kimoantiqe Awaiting requested review from kimoantiqe

@terryz21 terryz21 Awaiting requested review from terryz21

@nicholaschinjie nicholaschinjie Awaiting requested review from nicholaschinjie

@seifghazi seifghazi Awaiting requested review from seifghazi

Assignees
No one assigned
Labels
pr: finalized needs review and final approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobheadxi @yaoharry