-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: improved returns, debugging output #593
Conversation
defer testServer.Close() | ||
|
||
var d = newMockClient(t, testServer).GetUserClient() | ||
assert.NoError(t, d.RemoveUser(context.Background(), "yaoharry")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uwu
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
+ Coverage 55.36% 55.68% +0.32%
==========================================
Files 67 68 +1
Lines 3006 3226 +220
==========================================
+ Hits 1664 1796 +132
- Misses 1146 1197 +51
- Partials 196 233 +37
Continue to review full report at Codecov.
|
🎟️ Ticket(s): Closes #236
👷 Changes
oops... this turned out bigger than expected 😓
see #236 for context on this change
http.Response
, but relevant structures instead--debug
flag is now available to get debug output from the clientUserClient
, which you can get usingclient.Client.GetUserClient()
context.Context
for cleanliness of closure🔦 Testing Instructions