Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: deps update, remove yarn #635

Merged
merged 4 commits into from
Oct 31, 2019
Merged

web: deps update, remove yarn #635

merged 4 commits into from
Oct 31, 2019

Conversation

bobheadxi
Copy link
Member

🎟️ Ticket(s): follow-up #634


πŸ‘· Changes

#634 build seems to be failing on web build. Updated a few potential troublemakers and build works locally again

πŸ”¦ Testing Instructions

cd daemon/web
npm install
npm run build

@bobheadxi bobheadxi requested a review from a team October 31, 2019 17:31
@codecov
Copy link

codecov bot commented Oct 31, 2019

Codecov Report

Merging #635 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   55.81%   55.81%           
=======================================
  Files          68       68           
  Lines        3385     3385           
=======================================
  Hits         1889     1889           
  Misses       1253     1253           
  Partials      243      243

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 6f1cf43...56358d4. Read the comment docs.

@bobheadxi bobheadxi merged commit 68294e2 into master Oct 31, 2019
@bobheadxi bobheadxi deleted the web/deps-update branch October 31, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant