Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd(config): intermediary containers #639

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Conversation

bobheadxi
Copy link
Member

@bobheadxi bobheadxi commented Mar 5, 2020

🎟️ Ticket(s): Closes #607, for #633


👷 Changes

Add intermediary_containers option, similar to that added to v0.5.x in #608 for @rwblickhan

@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Mar 5, 2020
@bobheadxi bobheadxi requested a review from a team March 5, 2020 06:08
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #639 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
- Coverage   55.81%   55.56%   -0.24%     
==========================================
  Files          68       68              
  Lines        3385     3393       +8     
==========================================
- Hits         1889     1885       -4     
- Misses       1253     1264      +11     
- Partials      243      244       +1     
Impacted Files Coverage Δ
daemon/inertiad/auth/users.go 72.25% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729e2dc...c42444b. Read the comment docs.

@bobheadxi bobheadxi merged commit 9c8cc3c into master Mar 5, 2020
@bobheadxi bobheadxi deleted the cmd/intermediary-containers branch March 5, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: finalized needs review and final approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config: allow inertia to not panic and kill everything on container death
1 participant