Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: mount persistable directory #653

Merged
merged 4 commits into from
Mar 19, 2020
Merged

deploy: mount persistable directory #653

merged 4 commits into from
Mar 19, 2020

Conversation

bobheadxi
Copy link
Member

🎟️ Ticket(s): Closes #583


👷 Changes

A persisted directory is now mounted in both docker-compose and dockerfile deployments that projects can use to persist data, available as /persist:

https://github.com/ubclaunchpad/inertia/compare/deploy/persist-dir?expand=1#diff-cf2820f13d3ad9520509ce47a551e459R269

https://github.com/ubclaunchpad/inertia/compare/deploy/persist-dir?expand=1#diff-cf2820f13d3ad9520509ce47a551e459R269

@bobheadxi bobheadxi requested a review from a team March 19, 2020 21:25
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #653 into master will decrease coverage by 0.01%.
The diff coverage is 61.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
- Coverage   55.56%   55.56%   -0.00%     
==========================================
  Files          67       67              
  Lines        3393     3404      +11     
==========================================
+ Hits         1885     1891       +6     
- Misses       1265     1269       +4     
- Partials      243      244       +1     
Impacted Files Coverage Δ
daemon/inertiad/project/deployment.go 32.62% <40.00%> (-0.13%) ⬇️
daemon/inertiad/build/builder.go 74.20% <80.00%> (-0.30%) ⬇️
daemon/inertiad/cfg/config.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dc8d02...881777f. Read the comment docs.

@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Mar 19, 2020
@bobheadxi bobheadxi merged commit c7235d1 into master Mar 19, 2020
@bobheadxi bobheadxi deleted the deploy/persist-dir branch March 19, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: finalized needs review and final approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

daemon: support a persistent directory
1 participant