Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon(deployment): integrate slack config #661

Merged
merged 3 commits into from
Mar 22, 2020
Merged

Conversation

bobheadxi
Copy link
Member

🎟️ Ticket(s): Closes #621


👷 Changes

  • chore: fix counterfeiter runner
  • daemon(notify): add equality checker
  • daemon(deployment): integrate slack config

🔦 Testing Instructions

There are unit tests, set up slack workspace to try it out - see #585

@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Mar 22, 2020
@bobheadxi bobheadxi requested a review from a team March 22, 2020 21:32
@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #661 into master will decrease coverage by 0.15%.
The diff coverage is 77.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
- Coverage   55.70%   55.55%   -0.14%     
==========================================
  Files          67       69       +2     
  Lines        3431     3478      +47     
==========================================
+ Hits         1911     1932      +21     
- Misses       1274     1300      +26     
  Partials      246      246              
Impacted Files Coverage Δ
cfg/project.go 76.32% <ø> (ø)
daemon/inertiad/daemon/up.go 0.00% <0.00%> (ø)
daemon/inertiad/project/deployment.go 34.31% <85.72%> (+1.70%) ⬆️
client/client.go 73.73% <100.00%> (+0.42%) ⬆️
daemon/inertiad/notify/notifier.go 41.67% <100.00%> (ø)
daemon/inertiad/notify/slack.go 18.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f3cee...7183ae7. Read the comment docs.

@bobheadxi bobheadxi merged commit f386362 into master Mar 22, 2020
@bobheadxi bobheadxi deleted the daemon/slack-config branch March 22, 2020 21:46
@suujia
Copy link

suujia commented Mar 24, 2020

Looks good to me. Keep up the great work! 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: finalized needs review and final approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

daemon: integrate slack notification with config cycle
2 participants