Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewMountPointFromLine fails under WSL #72

Closed
stevenh opened this issue Jul 1, 2023 · 2 comments · Fixed by #73
Closed

NewMountPointFromLine fails under WSL #72

stevenh opened this issue Jul 1, 2023 · 2 comments · Fixed by #73

Comments

@stevenh
Copy link
Contributor

stevenh commented Jul 1, 2023

If you use NewMountPointFromLine on WSL it will fail due to the spacing in paths in super options.

   --- FAIL: TestLogger/default (0.00s)
        uber-go/automaxprocs/maxprocs/maxprocs_test.go:69: 
            	Error Trace:	maxprocs_test.go:69
            	Error:      	Received unexpected error:
            	            	invalid format for MountPoint: "560 77 0:138 / /Docker/host rw,noatime - 9p drvfs rw,dirsync,aname=drvfs;path=C:\\Program Files\\Docker\\Docker\\resources;symlinkroot=/mnt/,mmap,access=client,msize=262144,trans=virtio"
            	Test:       	TestLogger/default
            	Messages:   	Set failed
stevenh added a commit to stevenh/automaxprocs that referenced this issue Jul 1, 2023
@stevenh
fix: mountinfo parsing
820227b 
Fix the parsing of mountinfo when super options has fields with spaces
in, which is the case on WSL as it includes path=C:\\Program Files\...

Fixes uber-go#72
@stevenh stevenh mentioned this issue Jul 1, 2023
Merged
stevenh added a commit to stevenh/automaxprocs that referenced this issue Jul 12, 2023
@stevenh
fix: mountinfo parsing
d391614 
Fix the parsing of mountinfo when super options has fields with spaces
in, which is the case on WSL as it includes path=C:\\Program Files\...

Fixes uber-go#72
sywhang pushed a commit that referenced this issue Jul 19, 2023
@stevenh
fix: mountinfo parsing (#73)
60f2278 
Fix the parsing of mountinfo when super options has fields with spaces
in, which is the case on WSL as it includes path=C:\\Program Files\...

Fixes #72
@hhromic
Copy link

hhromic commented Jul 19, 2023

@sywhang this was a duplicate of #65. Given that release v1.5.3 fixes the issue, issue #65 should be closed too.
Btw, thanks for releasing a fix for this!

@sywhang
Copy link
Contributor

sywhang commented Jul 20, 2023

@hhromic thanks, closed #65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: mountinfo parsing stevenh/automaxprocs
3 participants
@stevenh @hhromic @sywhang