New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests on Windows #121

Merged

r-hang merged 1 commit into uber-go:main from craig65535:fix-win-unittests

Nov 9, 2023

Contributor

craig65535 commented Nov 9, 2023

To address #120


          Fix unit tests on Windows

563812a

Contributor

r-hang commented Nov 9, 2023

We should always be using forward slashes for package paths so the use of "path" which constrains to forwards slashes looks good to me.

ref: https://groups.google.com/g/Golang-nuts/c/bmKNJ1dkGiw/m/vgPCu6-5BAAJ

r-hang approved these changes

View reviewed changes

r-hang merged commit 7fb6390 into uber-go:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet