Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify TestParsePackageImport #53

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Simplify TestParsePackageImport #53

merged 1 commit into from
Aug 15, 2023

Conversation

alexandear
Copy link
Contributor

The PR refactors TestParsePackageImport by:

  • replacing os.Setenv with t.Setenv
  • using filepath.Join instead of manual paths concatenating;
  • adding missing error checks.

@sywhang sywhang requested a review from JacobOaks August 15, 2023 18:28
JacobOaks
JacobOaks approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@JacobOaks JacobOaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@JacobOaks JacobOaks merged commit ffb768a into uber-go:main Aug 15, 2023
2 checks passed
@alexandear alexandear deleted the simplify-test-parse-package-import branch August 16, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobOaks JacobOaks JacobOaks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @JacobOaks