Support type-safe InOrder and After #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-hang
requested changes
Sep 5, 2023
Currently when type-safe return values are used, one can't use `InOrder` neither `After` with them as they expect `*gomock.Call` as parameters. This changes the type these functions expect to be an interface which implements the `GetCall() *Call` method, which returns the embedded `*gomock.Call` type for generated mock types. Using this approach helps to have compile-time error/warnings instead of runtime errors with a reflection based solution. Fixes (#70)
EstebanOlmedo
force-pushed
the
eolmedo/interface-wrap-call
branch
from
0d99752
to
9b18c60
Compare
EstebanOlmedo
changed the title
marten-seemann
added a commit
to quic-go/quic-go
that referenced
this pull request
Sep 11, 2023
marten-seemann
added a commit
to quic-go/quic-go
that referenced
this pull request
Sep 11, 2023
marten-seemann
added a commit
to quic-go/quic-go
that referenced
this pull request
Sep 11, 2023
marten-seemann
added a commit
to quic-go/quic-go
that referenced
this pull request
Sep 11, 2023
marten-seemann
added a commit
to quic-go/quic-go
that referenced
this pull request
Sep 11, 2023
There was a problem hiding this comment.
I tried this PR out in quic-go/quic-go#4057 and it seems to work (CI failures are due to #80 and #81, which are unrelated to this PR).
Add a new exported interface `CallWrapper` which allow users to use `InOrder` and `After` with generated type-safe mock types.
|
Let's go with the approach #78 instead. The addition of this @marten-seemann could you try with #78 instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when type-safe return values are used, one can't use
InOrderneitherAfterwith them as they expect*gomock.Callas parameters. This changes the type these functionsexpect to be an interface which implements the
GetCall() *Callmethod,which returns the embedded
*gomock.Calltype for generated mock types.Using this approach helps to have compile-time error/warnings instead of
runtime errors with a reflection based solution.
Fixes (#70)