prevent race condition when reading from counters slice (#247)

uber-go · Mar 21, 2024 · 4386806 · 4386806
1 parent e2a71ea
commit 4386806
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/scope_registry.go b/scope_registry.go
@@ -309,6 +309,8 @@ func (r *scopeRegistry) reportInternalMetrics() {
 	scopes.Inc() // Account for root scope.
 	r.ForEachScope(
 		func(ss *scope) {
+			ss.cm.RLock()
+			defer ss.cm.RUnlock()
 			counterSliceLen, gaugeSliceLen, histogramSliceLen := int64(len(ss.countersSlice)), int64(len(ss.gaugesSlice)), int64(len(ss.histogramsSlice))
 			if ss.root { // Root scope is referenced across all buckets.
 				rootCounters.Store(counterSliceLen)