Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed indexing for accessing rotation order in Euler.getQuaternion #303

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Fixed indexing for accessing rotation order in Euler.getQuaternion #303

merged 1 commit into from
Feb 28, 2023

Conversation

TheBunyip
Copy link
Contributor

@TheBunyip TheBunyip commented Nov 24, 2022 •
edited
Loading

This was fixed some time back but appears to have regressed.

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AndrewPrifer
Copy link

I just ran into this now. Thanks for the PR @TheBunyip, I hope it gets merged soon.

@TheBunyip
Copy link
Contributor Author

Any chance this can get merged?

@ibgreen ibgreen merged commit 747a576 into uber-web:master Feb 28, 2023
@TheBunyip
Copy link
Contributor Author

Nice. Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheBunyip @CLAassistant @AndrewPrifer @ibgreen