Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collapse option to StatsWidget #166

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

isaacbrodsky
Copy link
Contributor

Click to collapse/expand, and also can be done via API. Also fixes bugs when multiple StatsWidgets are added to the same container but the stats weren't immediately available.

@coveralls
Copy link

coveralls commented Oct 7, 2021

Coverage Status

Coverage remained the same at 33.214% when pulling 14bfda5 on isaacbrodsky:stats-widget-collapse into a115366 on uber-web:master.

@isaacbrodsky
Copy link
Contributor Author

Since this is still open I added the remove() function to this PR as well. Happy to break that into a new PR if needed.

@ibgreen ibgreen merged commit 8147eb1 into uber-web:master Oct 20, 2021
@isaacbrodsky isaacbrodsky deleted the stats-widget-collapse branch October 20, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants