Refactor PreservedAnnotationTreeVisitor #955
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #955 +/- ##
============================================
- Coverage 86.11% 86.06% -0.06%
+ Complexity 2030 2027 -3
============================================
Files 81 81
Lines 6662 6679 +17
Branches 1291 1287 -4
============================================
+ Hits 5737 5748 +11
- Misses 512 518 +6
Partials 413 413 ☔ View full report in Codecov by Sentry. |
| @@ -156,6 +160,32 @@ private static MethodHandle createHandle() { | |||
| } | |||
| } | |||
|
|
|||
| private static MethodHandle createGetMetadataHandle() { | |||
There was a problem hiding this comment.
Remind me, all of these methods with reflection trickery are to avoid having a compile-time dep on JDK21, correct?
There was a problem hiding this comment.
A bunch of (internal) javac APIs changed between JDK 17 and 21 related to these TypeMetadata objects. On JDK 21+ we use reflection to operate on them since I expect that is used less for compiling than JDK 17 and before. Unfortunately I think we can only drop this reflection approach once we drop support for building on JDK 17. This is hacky, but the alternative that doesn't rely on internal APIs would require building up our own type data structures from scratch, like Checker Framework, which would be a lot more code.
We extract some code from
visitParameterizedTypeinto a propervisitAnnotatedTypemethod. This will be useful for an upcoming PR that handlesAnnotatedTypeTrees in new array expressions. The change introduces some complexity due to API changes in JDK 21, which we work around through further use ofMethodHandles.