Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host css and fonts locally #402

Closed
wants to merge 1 commit into from
Closed

Conversation

MrCalan
Copy link

@MrCalan MrCalan commented Sep 24, 2021

Fix issue #117

  • Downloaded remote fonts and css
  • Changed references from remote assets to local ones where needed
  • Added a loader for woff files in webpack.config.js

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


calan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@MrCalan
Copy link
Author

MrCalan commented Sep 24, 2021

I have signed the CLA but made the commit without configuring an e-mail address. Should i re-do the commit / PR ?

@just-at-uber
Copy link
Contributor

Hi @MrCalan , thanks for your contribution. I am just reviewing with legal to make sure we are ok with this change. One option I am considering is to make a new OS project which hosts these icons and simply pull into this project via an npm package. I am working with the open source team on this. Thank you.

@just-at-uber just-at-uber requested review from just-at-uber and a team September 24, 2021 17:51
@just-at-uber
Copy link
Contributor

just-at-uber commented Sep 24, 2021

you should be able to modify the commit and attach the email address. See link about ammend commit:
https://docs.github.com/en/github/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message

@Assem-Uber
Copy link
Contributor

Closing for long inactivity.

@Assem-Uber Assem-Uber closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants