Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip the zig-builder binary for reproducibility #124

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

dzbarsky
Copy link
Contributor

@dzbarsky dzbarsky commented Oct 6, 2023

Prior to this, I noticed builds ending up with different digests for the builder fairly often. Stripping those builder binaries manually made them match up; with this patch applied, I was able to have builds be 100% cached when trying 5 times (previously almost every time was a different digest).

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2023

CLA assistant check
All committers have signed the CLA.

@motiejus
Copy link
Collaborator

motiejus commented Oct 7, 2023

Did you validate it does become reproducible after this change? Please update the commit message with more details.

Code-wise lgtm

@dzbarsky
Copy link
Contributor Author

dzbarsky commented Oct 9, 2023

Yes, it looks reproducible to me; updated the summary.

@motiejus
Copy link
Collaborator

motiejus commented Oct 9, 2023

Yes, it looks reproducible to me; updated the summary.

This is good, thanks. Please rebase and add the description to the commit.

I noticed the release tests are broken, at some point we will take action on those. I cannot make any concrete time promises, but we will get to it.

@motiejus motiejus merged commit fd0bbf1 into uber:main Oct 10, 2023
2 checks passed
@motiejus
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants