This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
fix(map): fix water or multipolygons in general #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aemkei
suggested changes
Jun 11, 2018
| @@ -6,8 +6,6 @@ import Protobuf from 'pbf'; | |||
|
|
|||
| const API_KEY = 'fApLQBTwQbaIclmV0CoOQA'; | |||
| const TILE_BASE_URL = 'https://tile.nextzen.org/tilezen/vector/v1/256/all/'; | |||
| const EXCLUDE_ROAD_TYPES = ['ferry', 'path', 'minor_road', 'rail']; | |||
There was a problem hiding this comment.
At least we should exclude the 'ferry' type here.
There was a problem hiding this comment.
@pwambach Can you please have a look (next Friday)?
|
Excluded
|
|
Ah wait, there is still an error when merging the multiPolgons (the horizontal lines over the elbe) |
|
The problem are the tile borders in the MultiPolygons. Not sure how to fix that... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.