Permit generated to wrong address

[molecula451]

[ 29.5 WXDAI ]

@molecula451

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	4	18.3
Review	Comment	3	11.2

Conversation Incentives

Comment	Formatting	Relevance	Reward
i'm likely good with `require()` i would focus in gas optimizati...	8.8 li: count: 3 score: "3" words: 3 code: count: 1 score: "1" words: 1	0.7	8.8
> custom errors are preferred over require/assert. This definate...	5.4 code: count: 1 score: "1" words: 1	0.73	5.4
> I believe the contracts is being deployed on Ethereum mainnet....	1.4	0.45	1.4
custom erros can also be inside `require()` that's why the chang...	2.7 code: count: 1 score: "1" words: 1	0.51	2.7
Please fix the build actions as some are not passing...	1	0.31	1
Yeah i think the PR won't make it either as the such refactors s...	7.7	0.68	7.7
it looks like it took action on the PR closing but not on the is...	2.5	0.59	2.5

Clicking on it looks like the bot generated a permit to the wrong address

[0x4007]

This is a known issue for some people. @gitcoindev any ideas on how to fix it for everyone? Should we just drop the entire table and force re-registration?

[molecula451]

drop/invalidate that nonce meanwhile @pavlovcik

[gitcoindev]

@pavlovcik @molecula451 let me check in Supabase directly. In my case wallet id was null and I was able to manually correct the entry. I will check if this is the case for any other users in the database and try to fix this.

[molecula451]

in my case it generate to a wrong address (not mine) so it's not claimable even manually

btw pavlovcik both permit went generate to this wrong address from here too: ubiquity/ubiquity-dollar#830 (comment)

[gitcoindev]

/query @molecula451

[ubiquibot]

Property	Value
Wallet	0x19275E9fD721906F2715D4b78681b49da5088117

[molecula451]

/help

[ubiquibot]

Available Commands

Command	Description	Example
/start	Assign yourself to the issue.	/start
/stop	Unassign yourself from the issue.	/stop
/help	List all available commands.	/help
/query	Returns the user's wallet, access, and multiplier information.	/query @user
/ask	Ask a context aware question.	/ask is x or y the best approach?
/multiplier	Set the task payout multiplier for a specific contributor, and provide a reason for why.	/multiplier @user 0.5 "multiplier reason"
/labels	Set access control, for admins only.	/labels @user priority time price
/authorize	Approve a label change, for admins only.	/authorize
/wallet	Register your wallet address for payments.	/wallet ubq.eth

[molecula451]

/wallet 0x4D0704f400D57Ba93eEa88765C3FcDBD826dCFc4

[ubiquibot]

+ Successfully registered wallet address

[molecula451]

/query @molecula451

[ubiquibot]

Property	Value
Wallet	0x4D0704f400D57Ba93eEa88765C3FcDBD826dCFc4

[molecula451]

lol so look like the bot catch a wrong address to me @pavlovcik @gitcoindev i think it'll be good now

[gitcoindev]

@molecula451 from what I see your address was pointing to 0x19275E9fD721906F2715D4b78681b49da5088117, which is wallet id 35 in the wallets table and was assigned to a different username (h91....). Now you updated and it was corrected. I have found an old dump somewhere, will now double check other wallets to verify that it does not happen for anyone else. As for me @pavlovcik will have to send this one manually.

[gitcoindev]

This will take me a while, as db maps github user ids to wallet table with wallet ids, but extracting should be easy. I will definitely finish today checking this.

[molecula451]

i think pavlovick can hook a price label here to close to see if we're good to go

[ubiquibot]

+ Evaluating results. Please wait...

[ubiquibot]

[ 2.9 WXDAI ]

@pavlovcik

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	2.9

Conversation Incentives

Comment	Formatting	Relevance	Reward
This is a known issue for some people. @gitcoindev any ideas on ...	2.9	0.68	2.9

[ 111 WXDAI ]

@molecula451

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	93.6
Issue	Comment	4	17.4

Conversation Incentives

Comment	Formatting	Relevance	Reward
	93.6 code: count: 2 score: "2" words: 2	1	93.6
drop/invalidate that nonce meanwhile @pavlovcik ...	1.2	0.658	1.2
in my case it generate to a wrong address (not mine) so it's not...	8.2	0.681	8.2
lol so look like the bot catch a wrong address to me @pavlovcik...	4.2	0.506	4.2
i think pavlovick can hook a price label here to close to see if...	3.8	0.7	3.8

[ 14.3 WXDAI ]

@gitcoindev

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	3	14.3

Conversation Incentives

Comment	Formatting	Relevance	Reward
@pavlovcik @molecula451 let me check in Supabase directly. In my...	4.4	0.765	4.4
@molecula451 from what I see your address was pointing to 0x1927...	6.9	0.748	6.9
This will take me a while, as db maps github user ids to wallet ...	3	0.709	3

[0x4007]

lol all the specification details racked up a massive reward. Technically you should have used a block quote for the embedded permit data I guess

Anyways you should be able to see if the wallet address is correct without claiming.

---

I still am leaning towards dropping all the wallets and having everybody re-register them. We also must block the start command if they do not have a registered wallet in order to catch problems upstream as far as possible.

[molecula451]

yeah it's fixed! the bug now it's check the database for ALL users, to see if they have correct address, yeah doesn't look like it's calculating correct rewards eh?

[molecula451]

lmao i claimed before you posted that message pavlovcik

[gitcoindev]

And the unlucky winners are: ['wannacfuture', 'QuintusTheFifth', 'harjaapdhillon16', 'sweetapplepumpkinpie', 'Venoox', 'h918m', 'diamondnegroni', 'starlitnightsky', 'Ameralameri', 'web4er', 'b4s36t4', 'whilefoo', 'devtestubq', 'EtherealGlow']
Their wallet addresses differ from 2023 dump. I sent full details to @pavlovcik and suggest we drop the wallets table and ask everyone to register their wallet address again.