Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: errors are reported within the metadata of the Github comment #59

Conversation

gentlementlegen
Copy link
Member

Resolves #22

manifest.json Show resolved Hide resolved
@gentlementlegen
Copy link
Member Author

Changes

On success or failure, the url of the related run is added to the metadata of the Github comment. This helps seing more details about the root cause of the crash. On success, the generated result is posted as well.

QA run

Meniole#6 (comment)
Metadata content:

<!--
https://github.com/Meniole/conversation-rewards/actions/runs/9952235232
{
  "caller": "<anonymous>"
}
-->

@0x4007
Copy link
Member

0x4007 commented Jul 16, 2024

This technically is not the spec but it may also solve the problem in a better way.

@gentlementlegen gentlementlegen marked this pull request as ready for review July 16, 2024 09:34
@gentlementlegen
Copy link
Member Author

This technically is not the spec but it may also solve the problem in a better way.

What part is not in the spec, the URL to the Action run? Thought it was a nice to have, lemme know if that's fine. Just fixed the CI tests as well.

@gentlementlegen gentlementlegen merged commit e8474b3 into ubiquity-os-marketplace:development Jul 17, 2024
3 checks passed
@gentlementlegen gentlementlegen deleted the feat/error-reporting branch July 17, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qualitative Analysis: Error Message
4 participants