fix: call plugins synchronously #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rndquu instead of targeting development branch how about deploying this to its own branch then we can change the webhook url target of the bot? I don't know if you have access to this, if that's more complicated forget about this comment, changes look ok. |
I don't really want to mess anything in production bot settings so I'll just release a new kernel version with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #195
This PR basically reverts this commit and calls plugins synchronously one by one.
Not sure if that's is gonna solve the Cloudflare's
The script will never generate a responseerror. The plan is to deploy this PR and see how it goes.