NFT mints #146

whilefoo · 2023-12-20T21:51:48Z

still in the works

static/scripts/rewards/render-transaction/render-ens-name.ts

ubiquibot · 2023-12-31T13:58:44Z

88c8258

0ac7857

fd3260e

rndquu · 2024-01-03T12:18:50Z

@whilefoo So with this PR https://pay.ubq.fi accepts (in a query param) an array of exactly 2 values: our "traditional" permit and NFT mint request, right?

whilefoo · 2024-01-04T09:09:27Z

@whilefoo So with this PR https://pay.ubq.fi accepts (in a query param) an array of exactly 2 values: our "traditional" permit and NFT mint request, right?

it accepts any number of permits and NFT mint requests

0x4007 · 2024-01-06T22:56:49Z

Looks like this is good to go? Do you think it's finished @whilefoo ?

whilefoo · 2024-01-07T10:22:11Z

Looks like this is good to go? Do you think it's finished @whilefoo ?

Yes, it's good to go

0x4007

Normally I would handle this cosmetic change manually but I'm traveling at the moment and would rather get this merged in asap.

I noticed that the text for the new DOM elements is white, and when using the UI with light mode enabled, the text is very difficult to see. Please be sure to test by changing your OS settings to light mode and handling the CSS correctly.

The most "correct" way to handle this might be to refer to my other repository where I automatically generate an inverted brightness stylesheet during esbuild. I implemented this in work.ubq.fi repository.

If that's too complicated, then please just manually address your new DOM element colors.

0x4007 · 2024-01-07T20:29:10Z

static/scripts/rewards/render-transaction/utils.ts

@@ -0,0 +1,5 @@
+export function removeAllEventListeners(element: Element): Element {


You must remove the event listener manually. Deleting an element with an event listener from the DOM is not sufficient. I verified this with a quick perplexity search.

The problem is the mintNftHandler returns a new function every time but if you want to remove an event listener you need to give it the function that mintNftHandler returned when it was registered. It's not enough to call mintNftHandler again with the same parameters because it returns a new function so it doesn't work.

I'm pretty sure cloning an element and replacing it with the old one removes all event listeners because I tested it. You can also see here.

There's nothing on that page that says the event listener is removed when an element is removed from the DOM.

The problem is the mintNftHandler returns a new function every time

I don't follow. Are you saying it's hard to maintain a reference to the correct function to remove it as an event listener handler? I'm sure you can make an object at the highest scope and just use that as a cache. It doesn't seem like a complex problem.

whilefoo · 2024-01-11T21:49:32Z

The most "correct" way to handle this might be to refer to my other repository where I automatically generate an inverted brightness stylesheet during esbuild. I implemented this in work.ubq.fi repository.

I tried this but I had some issues with it because in work.ubq.fi there's only one CSS file but here we have multiple files that get imported by the main file for example rewards.css:

@import url("pay.css");
@import url("background.css");
@import url("claim-table.css");
@import url("media-queries.css");
@import url("../proxima.css");
@import url("../toast.css");
@import url("../fa.css");
@import url("light-mode.css");

and because esbuild runs the plugin only on the main CSS files it just creates rewards-inverted.css which has the same content as rewards.css and esbuild merges all these files into one CSS file but the plugin only processes input files and not output files.
Also we never actually use the esbuild output - when we deploy to Cloudflare we use the folder static, but the build folder is static/out.

I temporarily fixed the light mode manually and I will have to create a custom script that creates inverted CSS after the esbuild finishes its build, or if you have any other ideas how we can do that with the esbuild plugin.

0x4007 · 2024-01-12T05:08:47Z

The latest link doesn't seem to be fixed

https://814e7c5e.pay-ubq-fi-bxp.pages.dev

0x4007 · 2024-01-12T05:10:53Z

88c8258
0ac7857
fd3260e

Oh weird the ordering is backwards. We should fix this to display in chronological order.

0x4007 · 2024-01-22T17:28:46Z

Doesn't it make sense to hide the NFT rewards UI element unless we are passing in NFT reward related information in the query string? @whilefoo

0x4007 · 2024-02-22T07:43:11Z

static/scripts/rewards/render-transaction/tx-type.ts

+const NftMint = T.Object({
+  type: T.Literal("nft-mint"),
+  request: T.Object({
+    beneficiary: TAddress,
+    deadline: TBigNumber,
+    keys: T.Array(T.String()),
+    nonce: TBigNumber,
+    values: T.Array(T.String()),
+  }),
+  nftMetadata: T.Object({
+    GITHUB_ORGANIZATION_NAME: T.String(),
+    GITHUB_REPOSITORY_NAME: T.String(),
+    GITHUB_ISSUE_ID: T.String(),
+    GITHUB_USERNAME: T.String(),
+    GITHUB_CONTRIBUTION_TYPE: T.String(),
+  }),
+  nftAddress: TAddress,
+  networkId: TNetworkId,
+  signature: TSignature,
+});


I'm having type issues due to trying to process ERC20 and ERC721 permits in the UI code (the schemas don't line up at all.)

We should try and sync the properties as much as possible. I'm working on that now on my branch. I hope that it won't cause issues but I'm looking for input on constraints for the property names.

From what I understand if we change the property names then the old permits will be incompatible.

@whilefoo why not just copy the schema as much as possible of ERC20 permits to the ERC721 permits?

Because then you have erc721 specific properties like nftAddress, nftMetadata in erc20 type and the other way around so it's confusing

We should add an extra property specifically for NFTs then. That way its very easy to deal with the generic Permit type, and then extend for NftPermit

I only need to make the UI code compatible with the base Permit type and we are good to go.

feat: preparing for nft mints

a769ddb

0x4007 reviewed Dec 20, 2023

View reviewed changes

static/scripts/rewards/render-transaction/render-ens-name.ts Show resolved Hide resolved

whilefoo and others added 3 commits December 27, 2023 14:18

feat: multiple rewards

17bbf48

fix: remove previous button listeners

6f452aa

Merge branch 'development' into nft-mint

fd3260e

whilefoo marked this pull request as ready for review December 31, 2023 13:56

whilefoo requested a review from rndquu as a code owner December 31, 2023 13:56

whilefoo mentioned this pull request Dec 31, 2023

NFT rewards 0x4007/.ubiquity-os#7

Merged

feat: hide expiry field if it's too large, comma separated contributions

0ac7857

rndquu approved these changes Jan 4, 2024

View reviewed changes

0x4007 requested changes Jan 7, 2024

View reviewed changes

fix: light mode

88c8258

0x4007 approved these changes Jan 12, 2024

View reviewed changes

0x4007 merged commit 057a657 into ubiquity:development Jan 12, 2024
1 check passed

This was referenced Jan 25, 2024

Broken Permit Format ubiquibot/comment-incentives#3

Closed

Combine unclaimed permits tool #139

Closed

0x4007 reviewed Feb 22, 2024

View reviewed changes

0x4007 mentioned this pull request Feb 22, 2024

Sync ERC20 Permit and ERC721 Types System Wide ubiquity/.github#98

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NFT mints #146

NFT mints #146

whilefoo commented Dec 20, 2023

ubiquibot bot commented Dec 31, 2023 •

edited

Loading

rndquu commented Jan 3, 2024

whilefoo commented Jan 4, 2024

0x4007 commented Jan 6, 2024 •

edited

Loading

whilefoo commented Jan 7, 2024

0x4007 left a comment

0x4007 Jan 7, 2024

whilefoo Jan 8, 2024

0x4007 Jan 22, 2024 •

edited

Loading

whilefoo commented Jan 11, 2024

0x4007 commented Jan 12, 2024

0x4007 commented Jan 12, 2024

0x4007 commented Jan 22, 2024

0x4007 Feb 22, 2024 •

edited

Loading

whilefoo Feb 22, 2024

0x4007 Feb 22, 2024 •

edited

Loading

		@@ -0,0 +1,5 @@
		export function removeAllEventListeners(element: Element): Element {

NFT mints #146

NFT mints #146

Conversation

whilefoo commented Dec 20, 2023

ubiquibot bot commented Dec 31, 2023 • edited Loading

rndquu commented Jan 3, 2024

whilefoo commented Jan 4, 2024

0x4007 commented Jan 6, 2024 • edited Loading

whilefoo commented Jan 7, 2024

0x4007 left a comment

Choose a reason for hiding this comment

0x4007 Jan 7, 2024

Choose a reason for hiding this comment

whilefoo Jan 8, 2024

Choose a reason for hiding this comment

0x4007 Jan 22, 2024 • edited Loading

Choose a reason for hiding this comment

whilefoo commented Jan 11, 2024

0x4007 commented Jan 12, 2024

0x4007 commented Jan 12, 2024

0x4007 commented Jan 22, 2024

0x4007 Feb 22, 2024 • edited Loading

Choose a reason for hiding this comment

whilefoo Feb 22, 2024

Choose a reason for hiding this comment

0x4007 Feb 22, 2024 • edited Loading

Choose a reason for hiding this comment

ubiquibot bot commented Dec 31, 2023 •

edited

Loading

0x4007 commented Jan 6, 2024 •

edited

Loading

0x4007 Jan 22, 2024 •

edited

Loading

0x4007 Feb 22, 2024 •

edited

Loading

0x4007 Feb 22, 2024 •

edited

Loading