Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command array for help menu clarity #58

Closed
0x4007 opened this issue Jun 18, 2024 · 14 comments · Fixed by #71
Closed

command array for help menu clarity #58

0x4007 opened this issue Jun 18, 2024 · 14 comments · Fixed by #71

Comments

@0x4007
Copy link
Member

0x4007 commented Jun 18, 2024

@0x4007 Can be done just that the current design only allows for one command per uses configuration element, c.f. https://github.com/ubiquity/ubiquibot-kernel/blob/570b68e18639e9c38a90872cfb8cbfbbdf661481/src/github/types/plugin-configuration.ts#L60
We could consider supporting an array of command instead of just one element.

Originally posted by @gentlementlegen in Meniole/ubiquity-os-kernel#2 (comment)

@0x4007
Copy link
Member Author

0x4007 commented Jun 18, 2024

@gentlementlegen please set time label.

@gentlementlegen
Copy link
Member

gentlementlegen commented Jun 19, 2024

To consider for a better use of the /help command: #56


Let's have a manifest that will be responsible to describe the command, give examples and so on, as described in this comment. I will update the time accordingly, because I think it's a long task since every plugin has to be updated as well.

Copy link

ubiquibot bot commented Jul 9, 2024

@gentlementlegen, You are not allowed to remove Time: <2 Hours

@ubiquibot ubiquibot bot removed the Time: <1 Day label Jul 9, 2024
Copy link

ubiquibot bot commented Jul 9, 2024

@gentlementlegen, You are not allowed to add Time: <1 Day

Copy link

ubiquibot bot commented Jul 9, 2024

! No permission to set labels

1 similar comment
Copy link

ubiquibot bot commented Jul 9, 2024

! No permission to set labels

@gentlementlegen
Copy link
Member

Well @0x4007 I think 1 day is reasonable 😄

@gentlementlegen
Copy link
Member

/start

Copy link

ubiquibot bot commented Jul 9, 2024

DeadlineTue, Jul 9, 6:48 AM UTC
Registered Wallet 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquibot bot commented Jul 17, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot-dev bot commented Jul 17, 2024

[ 273.86 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Task 1 200
Issue Comment 2 0
Review Comment 8 73.86
Conversation Incentives
Comment Formatting Relevance Reward
To consider for a better use of the `/help` command: htt…
0
content:
  p:
    count: 56
    score: 1
  code:
    count: 1
    score: 1
  a:
    count: 2
    score: 1
wordValue: 0
formattingMultiplier: 0
0.85 -
Well @0x4007 I think 1 day is reasonable 😄
0
content:
  p:
    count: 9
    score: 1
wordValue: 0
formattingMultiplier: 0
0.1 -
Resolves #58
0
content:
  p:
    count: 2
    score: 1
wordValue: 0
formattingMultiplier: 0
0.7 -
@0x4007 I will add it in the plugin template as well. Currently …
44.8
content:
  p:
    count: 111
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
0.4 17.92
The standard web schema has a `commands` section but it …
22.4
content:
  p:
    count: 55
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.2
formattingMultiplier: 2
0.5 11.2
We are still using `bun`, I'll check if I can add this b…
10.8
content:
  p:
    count: 25
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.2
formattingMultiplier: 2
0.65 7.02
## What's new The command description and example is now taken f…
72.8
content:
  h2:
    count: 164
    score: 1
  code:
    count: 15
    score: 1
  a:
    count: 3
    score: 1
wordValue: 0.2
formattingMultiplier: 2
0.2 14.56
@whilefoo Are you still using `bun` for the runtime then…
17.6
content:
  p:
    count: 42
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.2
formattingMultiplier: 2
0.3 5.28
@whilefoo I fixed all the tests within https://github.com/ubiqui…
3.2
content:
  p:
    count: 8
    score: 1
wordValue: 0.2
formattingMultiplier: 2
0.9 2.88
I will add an example. I also added boilerplate code within the …
20
content:
  p:
    count: 47
    score: 1
  code:
    count: 1
    score: 1
  a:
    count: 2
    score: 1
wordValue: 0.2
formattingMultiplier: 2
0.75 15

[ 0 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Conversation Incentives
Comment Formatting Relevance Reward

[ 1.82 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Review Comment 4 1.82
Conversation Incentives
Comment Formatting Relevance Reward
Approving this with failing tests because, as far as I understan…
1.7
content:
  p:
    count: 17
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
@gentlementlegen So what package manager should be used for the …
1.6
content:
  p:
    count: 14
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
@gentlementlegen Could you update readme with an example for …
3.4
content:
  p:
    count: 33
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.3 1.02
Oh, the example exists [here](https://github.com/ubiquibot/plugi…
2
content:
  p:
    count: 19
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.4 0.8

[ 1.3 WXDAI ]

@whilefoo
Contributions Overview
View Contribution Count Reward
Review Comment 4 1.3
Conversation Incentives
Comment Formatting Relevance Reward
why does example need a prefix?
0.6
content:
  p:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.1 0.06
isn't `commands` an object like the schema in `manif…
1.1
content:
  p:
    count: 9
    score: 1
  code:
    count: 2
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.4 0.44
I think it's not a good idea to run tests with different runtime…
3.6
content:
  p:
    count: 35
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.2 0.72
It's only being used as a package manager
0.8
content:
  p:
    count: 8
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.1 0.08

Copy link

ubiquibot bot commented Jul 17, 2024

[ 3 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueSpecification12
IssueComment11
Conversation Incentives
CommentFormattingRelevanceReward
> @0x4007 Can be done just that the current design only allow...
2
code:
  count: 2
  score: "2"
  words: 2
12
@gentlementlegen please set time label....
10.261

[ 319.2 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask1200
IssueComment20
IssueComment210.2
ReviewComment454.5
ReviewComment454.5
Conversation Incentives
CommentFormattingRelevanceReward
To consider for a better use of the `/help` command: htt...
-
a:
  count: 1
  score: "0"
  words: 2
code:
  count: 1
  score: "0"
  words: 1
hr:
  count: 1
  score: "0"
  words: 0
0.75-
Well @0x4007 I think 1 day is reasonable 😄 ...
-0.21-
To consider for a better use of the `/help` command: htt...
9.4
a:
  count: 1
  score: "1"
  words: 2
code:
  count: 1
  score: "1"
  words: 1
hr:
  count: 1
  score: "1"
  words: 0
0.759.4
Well @0x4007 I think 1 day is reasonable 😄 ...
0.80.210.8
## What's new The command description and example is now taken ...
39
h2:
  count: 3
  score: "3"
  words: 9
a:
  count: 1
  score: "1"
  words: 3
li:
  count: 2
  score: "2"
  words: 48
code:
  count: 15
  score: "15"
  words: 25
0.2239
@whilefoo Are you still using `bun` for the runtime then...
6.2
code:
  count: 2
  score: "2"
  words: 2
0.476.2
@whilefoo I fixed all the tests within https://github.com/ubiqui...
1.50.721.5
> @gentlementlegen Could you update readme with an example fo...
7.8
a:
  count: 1
  score: "1"
  words: 2
code:
  count: 2
  score: "2"
  words: 4
0.457.8
## What's new The command description and example is now taken ...
39
h2:
  count: 3
  score: "3"
  words: 9
a:
  count: 1
  score: "1"
  words: 3
li:
  count: 2
  score: "2"
  words: 48
code:
  count: 15
  score: "15"
  words: 25
0.2239
@whilefoo Are you still using `bun` for the runtime then...
6.2
code:
  count: 2
  score: "2"
  words: 2
0.476.2
@whilefoo I fixed all the tests within https://github.com/ubiqui...
1.50.721.5
> @gentlementlegen Could you update readme with an example fo...
7.8
a:
  count: 1
  score: "1"
  words: 2
code:
  count: 2
  score: "2"
  words: 4
0.457.8

[ 10.4 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
ReviewComment210.4
Conversation Incentives
CommentFormattingRelevanceReward
@gentlementlegen Could you update readme with an example for ...
4.4
code:
  count: 1
  score: "1"
  words: 2
0.584.4
> > @gentlementlegen Could you update readme with an examp...
6
a:
  count: 2
  score: "2"
  words: 3
code:
  count: 2
  score: "2"
  words: 4
0.326

[ 9.6 WXDAI ]

@whilefoo
Contributions Overview
ViewContributionCountReward
ReviewComment29.6
Conversation Incentives
CommentFormattingRelevanceReward
> `bun` is broken with `msw` before release &...
7.7
code:
  count: 4
  score: "4"
  words: 6
0.117.7
> @whilefoo Are you still using `bun` for the runtime...
1.9
code:
  count: 1
  score: "1"
  words: 1
0.771.9

@0x4007
Copy link
Member Author

0x4007 commented Jul 17, 2024

V2 still missing stuff for my rewards. Also if 0 it shouldn't render anything for me. Because it did I think that's a clear symptom of a bug.

@gentlementlegen
Copy link
Member

@0x4007 It has ignored your spec and your comment. Also quoted it in a ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants