Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

fix: fix ERR_REQUIRE_ESM #377

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Jun 6, 2023

This PR fixes this error

The mdast-util-from-markdown is an ESM module. Our project setup does not support such modules (we support only commonjs modules). As soon as probot moves to ESM we can also enable full ESM support for our project.

@rndquu rndquu requested a review from 0xcodercrane as a code owner June 6, 2023 13:35
@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for ubiquibot-staging ready!

Name Link
🔨 Latest commit 945df18
🔍 Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/647f361e05f0570008bcad4b
😎 Deploy Preview https://deploy-preview-377--ubiquibot-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@0xcodercrane
Copy link
Contributor

This error is really frustrating because it is happening to most of the bounty hunters recently. I just want to make sure this will resolve it finally. @rndquu if you are 100% sure, lets merge it

@rndquu
Copy link
Member Author

rndquu commented Jun 6, 2023

This error is really frustrating because it is happening to most of the bounty hunters recently. I just want to make sure this will resolve it finally. @rndquu if you are 100% sure, lets merge it

I'm sure, you are free to merge it

@0xcodercrane 0xcodercrane merged commit e9997ff into ubiquity:development Jun 6, 2023
@rndquu rndquu deleted the fix/mdast-require-esm branch June 25, 2023 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants