-
Notifications
You must be signed in to change notification settings - Fork 61
Parse Permit Url #738
Parse Permit Url #738
Conversation
URL object
✅ Deploy Preview for ubiquibot-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also post QA
- removing unused import statement
the parsing should be done with URLSearchParams to avoid dependence on param order like @Sadaf-A did. I don't understand why you changed it to regex |
@whilefoo |
yes I know @0xcodercrane made those changes |
We don't create a complex claim URL here, so I guess no need to worry about the param order. In upper lines, we were also using regex so wanted to make the parse consistent. If the order problem happens, lets update it at that time. |
This isn't the spec |
@whilefoo @pavlovcik should i open another PR for this? |
Resolves #526