-
Notifications
You must be signed in to change notification settings - Fork 61
Refactor/move to delegated compute #920
Refactor/move to delegated compute #920
Conversation
Feat/fix label issues
feat: remove axios call
…-call Revert "feat: remove axios call"
Looks like there were some small changes around database operations for NFTs by whilefoo and switching the logger to gitcoindev's npm module |
- name: Enable Corepack and Install Correct Yarn Version | ||
run: | | ||
corepack enable | ||
yarn set version 4.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the core pack stuff and use yarn 1.2 or whatever is the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. If I remember correctly it was a workaround from @wannacfuture and it had to be added to avoid an error but I do not remember the root cause for introducing this change.
@whilefoo @gitcoindev just wanted to know if your changes all look intact. This is being merged sort of out of order and wanted to make sure we are not causing problems with this merge. |
I am on it, will review asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving from my side. The logger changes integration looks fine. I hope nothing was skipped.
- name: Enable Corepack and Install Correct Yarn Version | ||
run: | | ||
corepack enable | ||
yarn set version 4.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. If I remember correctly it was a workaround from @wannacfuture and it had to be added to avoid an error but I do not remember the root cause for introducing this change.
e45abb5
into
ubiquity:refactor/move-to-delegated-compute
Exploring what was not included