Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

chore: update knip configuration to run on pull_request #932

Conversation

gitcoindev
Copy link
Contributor

Resolves #931

@gitcoindev gitcoindev requested a review from rndquu May 24, 2024 10:13
@gitcoindev
Copy link
Contributor Author

The same configuration update as for other repositories, with one change as knip is triggered using bun.
The findings are still present but the chance to leak org secrets will be gone.

@rndquu
Copy link
Member

rndquu commented May 27, 2024

https://github.com/ubiquity/ubiquibot repo is kind of deprecated in favour of https://github.com/ubiquity/ubiquibot-kernel so it makes sense to save time fixing knip errors

@rndquu rndquu merged commit d6b2083 into ubiquity:development May 27, 2024
5 of 6 checks passed
@gitcoindev
Copy link
Contributor Author

https://github.com/ubiquity/ubiquibot repo is kind of deprecated in favour of https://github.com/ubiquity/ubiquibot-kernel so it makes sense to save time fixing knip errors

Hi @rndquu I am aware of the deprecation. The latest merge #929 happened last week though, and I decided to fix this also here to avoid leaking secrets.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: refactor knip to run on pull_request eventTask
2 participants